Skip to content

fix: allow Api model without properties #2709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2022
Merged

fix: allow Api model without properties #2709

merged 4 commits into from
Dec 7, 2022

Conversation

hoffa
Copy link
Contributor

@hoffa hoffa commented Dec 7, 2022

Issue #, if available

#1559

Description of changes

JSON schema doesn't require properties at the top-level, see e.g. https://json-schema.org/understanding-json-schema/reference/array.html#items.

Description of how you validated changes

Checklist

  • Adheres to the development guidelines
  • Add/update unit tests using:
  • Add/update integration tests
  • Update documentation
  • Verify transformed template deploys and application functions as expected
  • Do these changes include any template validations?
    • Did the newly validated properties support intrinsics prior to adding the validations? (If unsure, please review Intrinsic Functions before proceeding).
      • Does the pull request ensure that intrinsics remain functional with the new validations?

Examples?

Please reach out in the comments, if you want to add an example. Examples will be
added to sam init through https://github.com/awslabs/aws-sam-cli-app-templates/

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hoffa hoffa requested a review from a team as a code owner December 7, 2022 19:35
@hoffa hoffa merged commit a82a19f into aws:develop Dec 7, 2022
@hoffa hoffa deleted the fix-1559 branch December 7, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants