-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.0.5 #148
Release 2.0.5 #148
Conversation
3535a13
to
fe5f1b7
Compare
setup.py
Outdated
('software.amazon.awssdk', 'kinesis', '2.16.98'), | ||
('software.amazon.awssdk', 'aws-cbor-protocol', '2.16.98'), | ||
('software.amazon.kinesis', 'amazon-kinesis-client-multilang', '2.3.7'), | ||
('software.amazon.kinesis', 'amazon-kinesis-client', '2.3.7'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release note in README says 2.3.8
, but looks like the version is 2.3.7
here. Should we fix so that the version is consistent?
setup.py
Outdated
('software.amazon.awssdk', 'protocol-core', '2.17.52'), | ||
('software.amazon.awssdk', 'profiles', '2.17.52'), | ||
('software.amazon.awssdk', 'sdk-core', '2.17.52'), | ||
('software.amazon.awssdk', 'sdk-core', '2.17.52'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicated sdk-core
README.md
Outdated
* Amazon Kinesis Client Library 2.3.8 | ||
* AWS SDK 2.17.52 | ||
* Added dependencies | ||
* AWS SDK json-utils |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: do we need to specify the version to be consistent?
README.md
Outdated
* AWS SDK 2.17.52 | ||
* Added dependencies | ||
* AWS SDK json-utils | ||
* third-party-jackson 2.17.52 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: looks like we are adding third-party-jackson-core
and third-party-jackson-dataformat-cbor
, not sure if they make up third-party-jackson
but might be nice to list the specific dependencies we are adding
96bf74f
to
9535214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up the dependencies!
Issue #, if available:
Release 2.0.5 with dependencies upgrade
Description of changes:
Release 2.0.5 (November 11, 2021)
Testing
Tested with changed sample.properties, look for
ShardFilter=ShardFilter(Type=AT_TIMESTAMP, Timestamp=2021-11-11T05:39:02Z))
in the below output for test resultBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.