Upgrade to AWS SDK v2 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mngo87
commented
Sep 17, 2020
| String errorMessage = "SNS extended client does not support sending JSON messages."; | ||
| LOGGER.error(errorMessage); | ||
| throw new AmazonClientException(errorMessage); | ||
| } | ||
|
|
||
| publishRequest.getRequestClientOptions().appendUserAgent(USER_AGENT_HEADER); | ||
| PublishRequest.Builder publishRequestBuilder = publishRequest.toBuilder(); | ||
| publishRequestBuilder.overrideConfiguration(AwsRequestOverrideConfiguration.builder().putHeader(USER_AGENT_HEADER_NAME, USER_AGENT_HEADER).build()); |
There was a problem hiding this comment.
I wasn't sure if there was a better way to handle this. Please advise here
|
I am unable to specify reviewers. so tagging @aws-ivvladim @aws-rizi |
aws-rizi
suggested changes
Sep 21, 2020
src/main/java/software/amazon/sns/AmazonSNSExtendedClientBase.java
Outdated
Show resolved
Hide resolved
|
Thanks for the review @aws-rizi. I updated the comments per your request |
aws-rizi
suggested changes
Sep 24, 2020
| @@ -1,6 +1,8 @@ | |||
| package software.amazon.sns; | |||
|
|
|||
| import software.amazon.awssdk.core.exception.SdkClientException; | |||
| import java.util.function.Consumer; | |||
There was a problem hiding this comment.
- We have following methods in that are not implemented in this class, so if somebody calls them on instance of
1) default ListEndpointsByPlatformApplicationIterable listEndpointsByPlatformApplicationPaginator(
ListEndpointsByPlatformApplicationRequest listEndpointsByPlatformApplicationRequest)
2) default ListPlatformApplicationsIterable listPlatformApplicationsPaginator(
ListPlatformApplicationsRequest listPlatformApplicationsRequest)
3) default ListSubscriptionsIterable listSubscriptionsPaginator(ListSubscriptionsRequest listSubscriptionsRequest)
4) default ListSubscriptionsByTopicIterable listSubscriptionsByTopicPaginator(
ListSubscriptionsByTopicRequest listSubscriptionsByTopicRequest)
5) default ListTopicsIterable listTopicsPaginator(ListTopicsRequest listTopicsRequest)
could you please override these methods as well here?
- Please add exceptions to the methods to be consistent with DefaultSnsClient.java in software.amazon.awssdk.services.sns. (In both AmazonSNSExtendedClientBase.java and AmazonSNSExtendedClient.java)
as sample:
@Override
public AddPermissionResponse addPermission(AddPermissionRequest addPermissionRequest) throws InvalidParameterException,
InternalErrorException, AuthorizationErrorException, NotFoundException, AwsServiceException, SdkClientException,
SnsException {
src/main/java/software/amazon/sns/AmazonSNSExtendedClientBase.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/sns/AmazonSNSExtendedClientTest.java
Outdated
Show resolved
Hide resolved
mngo87
commented
Sep 24, 2020
|
Hey any updates on this? Support for SDK V2 would be awesome! I am willing to contribute. What needs to be done here that's still remaining? How do we move this forward? |
|
Now that awslabs/amazon-sqs-java-extended-client-lib#58 has been merged can we get the dependency updated in this PR and get it merged in? |
shih
reviewed
Oct 5, 2022
shih
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#7
Description of changes:
Ensure this library is compatible with Java SDK V2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.