Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Support for echo router v4 #41

Closed
jackwellsxyz opened this issue Jul 11, 2019 · 9 comments
Closed

Support for echo router v4 #41

jackwellsxyz opened this issue Jul 11, 2019 · 9 comments

Comments

@jackwellsxyz
Copy link

Hello! Could we upgrade the echo module to support version 4? I have a dependency that returns a v4 echo router (and it seems to be the favored version on the github page), but I can't integrate it with the aws-lambda-go-api-proxy. I can do a very quick pull request that either adds support for both versions, or alternatively changes the import to github.com/labstack/echo/v4 if you'd like.

Thanks!

@sapessi
Copy link
Collaborator

sapessi commented Jul 30, 2019

Hi @jackwellsxyz - v4 of echo is a major release that includes breaking changes. I'll dig deeper into what the changes are and if needed I'll pull it in a separate package (/echov4).

@Ropelatto
Copy link

Ropelatto commented Nov 1, 2019

Hi,

When will it be released?

Thanks!

@tyd
Copy link

tyd commented Feb 6, 2020

@sapessi Any update as to when this will be merged and released? Thanks

@sapessi
Copy link
Collaborator

sapessi commented Feb 6, 2020

#50 addresses this. There are some changes needed but we should be close.

@excavador
Copy link

Any updates?

@sapessi
Copy link
Collaborator

sapessi commented May 26, 2020

I'll look at this between today and tomorrow. Apologies for the delay.

@jnathanh
Copy link

It looks like the major version change was switching to go modules. I copied https://github.com/awslabs/aws-lambda-go-api-proxy/blob/master/echo/adapter.go and added the /v4 to the echo import and it's working just fine.

@lucasmdomingues
Copy link

v4 is available ?

@sapessi
Copy link
Collaborator

sapessi commented Jul 27, 2020

Closing since #71 was just merged and v0.8.0 tagged as a release

@sapessi sapessi closed this as completed Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants