Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Invalid Iris dependency #70

Closed
adam-debkowski opened this issue Jul 27, 2020 · 7 comments
Closed

Invalid Iris dependency #70

adam-debkowski opened this issue Jul 27, 2020 · 7 comments

Comments

@adam-debkowski
Copy link

Since today I'm unable to build my go application using aws-lambda-go-api-proxy due to an invalid version of the iris dependency.

go test ./... -covermode=count -count=1
go: github.com/awslabs/[email protected] requires
	github.com/kataras/[email protected]+incompatible: reading github.com/kataras/iris/go.mod at revision v11.1.1: unknown revision v11.1.1

And after looking into the github.com/kataras/iris, there is no v11.1.1 version. At this point, I'm not sure how did it work before - did the github.com/kataras/[email protected] got deleted from their github, or am I missing something?

@sapessi
Copy link
Collaborator

sapessi commented Jul 27, 2020

I just tried to run the same command on my machine and it worked. I have attempted to clean the ~/go/pkg/mod cache and every time I see the [email protected]+incompatible folder reappear. Weirdly, I cannot see the v11 tag in the iris repo either.

@mescam
Copy link

mescam commented Jul 27, 2020

@sapessi
It's because you are downloading cached version from proxy.golang.org.

The maintainer of iris said that he deleted all of legacy tags: kataras/iris#1571

@kataras
Copy link
Contributor

kataras commented Jul 27, 2020

Iris users were not the only ones left behind by using legacy package import (github.com/kataras/iris instead of github.com/kataras/irisv12). The users of echo web framework, was left behind too. Echo's latest version is v4 (github.com/labstack/echo/v4) but this package requires the github.com/labstack/echo (which was version 3).

So, I am preparing a PR which will update all dependencies, including Iris and Echo.

kataras added a commit to responsibility-act/aws-lambda-go-api-proxy that referenced this issue Jul 27, 2020
@kataras
Copy link
Contributor

kataras commented Jul 27, 2020

OK It's done, it was a simple task. Please vote up or comment your opinion at: #71.

Thanks,
Gerasimos Maropoulos.

@sapessi
Copy link
Collaborator

sapessi commented Jul 27, 2020

I'm working on the iris update now. Echo is a bigger breaking change. I think we should just switch to #65 and simply support the http adapter. We can then give samples that show how to use it with each framework.

@sapessi
Copy link
Collaborator

sapessi commented Jul 27, 2020

See #72 - I may merge and tag as a major release

sapessi pushed a commit that referenced this issue Jul 27, 2020
@sapessi
Copy link
Collaborator

sapessi commented Jul 27, 2020

Closing since we merged #71

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants