Have TravisCI cache cargo between builds. #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may want to keep in mind some of the caveats identied of this approach listed in this post |
|
Thanks @softprops! That motivated me to not have the the cache initially, but then I noticed Travis took ~30 minutes to run, whereas other projects I worked on (Tokio Trace, for one) took maybe 2 minutes. The only difference was the presence of cached Travis CI. I’m open to re-evaluating this choice, however! |
|
Hmm, the issue seems to be related to the fact that we're building for macOS. It might make sense to skip building for macOS. |
|
Yeah. No need to build for macos |
|
It's not about not caching but what to cache. There's some notes in the post on more focused dirs to cache. |
|
Thanks @softprops. I've added the caching strategy that the article recommended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
see title.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.