Skip to content

fix: don't panic on missing headers under SAM #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Fishrock123
Copy link

@Fishrock123 Fishrock123 commented May 4, 2021

Description of changes:

SAM is missing these headers, making local testing impossible without this change.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

SAM is missing these, making local testing impossible without this change.
Copy link
Contributor

@coltonweaver coltonweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the first time we've received this request, and I understand the issue you're facing. However, I don't believe that this runtime is the right place to inject these default values, and could lead to weird behavior for developers relying on this in production Lambda.

#314

I would recommend looking at the comment made by @davidbarsky on this previous PR and reach out to the upstream repo to try and fix this regression. aws/aws-sam-cli#2715

@coltonweaver
Copy link
Contributor

I'm going to close this PR as I don't believe this runtime to be the right place to try and remediate this issue. If you strongly disagree, please feel free to reply and we can discuss.

@Fishrock123
Copy link
Author

I feel like it should be vocal about these missing somehow but I don't know that it is worth crashing? Not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants