Skip to content

Removed references to type Error aliases in docs #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

rimutaka
Copy link
Contributor

@rimutaka rimutaka commented Nov 21, 2021

We removed the need to define an alias for our internal Error type in this commit 96fc5bc a while back. I've just noticed that some internal docs didn't get updated.

Description of changes

  • removed alias definition
  • added Error to use

I didn't run the examples, but this is a 1:1 copy from my working code.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

* removed alias definition
* added Error to `use`
Copy link
Contributor

@coltonweaver coltonweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the update!

@coltonweaver coltonweaver merged commit 154cf31 into awslabs:master Nov 21, 2021
@nmoutschen nmoutschen added the 0.5 label Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants