Skip to content

add parity to the lambda macro to support handler closure impl #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2018

Conversation

softprops
Copy link
Contributor

Issue #, if available:

Description of changes:

This is a follow up to #19 to add support for the new closure style handlers with the lambda! macro. I made attempt to hit to birds (docs and tests) with on doctest coverage.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@davidbarsky
Copy link
Contributor

This looks great, thank you!

@davidbarsky
Copy link
Contributor

Ugh, can you resolve the merge issues? Sorry about that.

@softprops
Copy link
Contributor Author

yep

@softprops
Copy link
Contributor Author

updated

Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidbarsky davidbarsky merged commit 838d130 into awslabs:master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants