Skip to content

Relax Send constraint in lambda-http #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

fmonniot
Copy link
Contributor

@fmonniot fmonniot commented Mar 9, 2022

Issue #, if available: #342 and #344

Description of changes:

It looks like the switch to tower::Service re-introduced the Send constraint on Future and Service in the lambda-http crate. The lambda-runtime crate does not have them so it seems unintentional. This change remove the Send constraint in the lambda-http crate.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

Copy link
Contributor

@nmoutschen nmoutschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR!

@nmoutschen nmoutschen merged commit 0d6b25a into awslabs:main Mar 9, 2022
@fmonniot fmonniot deleted the relax-send-constraint branch March 9, 2022 08:35
@fmonniot
Copy link
Contributor Author

fmonniot commented Mar 10, 2022

Thanks @nmoutschen for the quick merge. Do you know if there is a plan to release a new version of the library relatively soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants