Skip to content

remove stage from generated http request url #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

bnusunny
Copy link
Contributor

Issue #, if available:

Issue #450

Description of changes:

This PR removes stage from generated http request url. This is the behavior in v0.4.1.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this, tbh. I'd like to understand why this needs to be reverted when it was a fix for a customer problem.

see for context on this behavior, #107

See my comment about stage behavior here: #450 (comment)

@calavera
Copy link
Contributor

@bnusunny please open a different pull request for the User-Agent change.

@bnusunny
Copy link
Contributor Author

Sorry. My mistake.

@bnusunny bnusunny closed this Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants