Skip to content

lambda_http: Add convenience methods to get references to data in the request #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2023
Merged

lambda_http: Add convenience methods to get references to data in the request #602

merged 2 commits into from
Feb 21, 2023

Conversation

dcormier
Copy link
Contributor

Description of changes:

There are existing methods to get owned clones of various pieces of data in the Request. This adds methods to get references where owned data is not needed.

Also fixed a typo in docs, and some typos in tests.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

dcormier
dcormier commented Feb 17, 2023
View reviewed changes
@dcormier
Copy link
Contributor Author

I'm inclined to have those two methods I commented on return Option rather than panic. Thoughts?

@bnusunny
Copy link
Contributor

Thanks for contributing. I agree returning Option is better.

@dcormier
Copy link
Contributor Author

Done.

@bnusunny
Copy link
Contributor

Could you merge the latest main branch into this PR? It contains fixes for clippy issues and won't break the builds.

@dcormier
Fixed some types in docs and tests
b3b522a
@dcormier
Add convenience methods to get references to data in the request
8cea97e 
There are existing methods to get owned clones of various pieces of data
in the `Request`. This adds methods to get references where owned data
is not needed.
@dcormier
Copy link
Contributor Author

Done.

@dcormier dcormier mentioned this pull request Feb 20, 2023
Closed
@bnusunny bnusunny merged commit 17ef2a2 into awslabs:main Feb 21, 2023
@dcormier dcormier mentioned this pull request Apr 10, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnusunny bnusunny bnusunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcormier @bnusunny