Skip to content

Add support for Lambda streaming response #628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 9, 2023
Merged

Add support for Lambda streaming response #628

merged 6 commits into from
Apr 9, 2023

Conversation

bnusunny
Copy link
Contributor

@bnusunny bnusunny commented Apr 8, 2023

This PR adds support for Lambda steaming response feature.

A new code path is added to both lambda-runtime and lambda-http crates due to the changed function signature.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

calavera
calavera reviewed Apr 8, 2023
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you add an example in the examples directory?

@bnusunny
Copy link
Contributor Author

bnusunny commented Apr 9, 2023

Sure. Just added one example: basic-streaming-response.

@bnusunny bnusunny requested a review from calavera April 9, 2023 01:53
calavera
calavera approved these changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@calavera calavera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@bnusunny bnusunny merged commit 3ee4389 into main Apr 9, 2023
@bnusunny bnusunny deleted the streaming_response branch April 9, 2023 05:06
@anmonteiro anmonteiro mentioned this pull request Apr 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calavera calavera calavera approved these changes

@timClicks timClicks Awaiting requested review from timClicks

@greenwoodcm greenwoodcm Awaiting requested review from greenwoodcm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnusunny @calavera