-
Notifications
You must be signed in to change notification settings - Fork 361
[Do not merge] Refactor to address RFCs #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 41 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
a77abb1
Fixed typo for UNHANDLED error constant
sapessi 36bcc8f
Removed RuntimeApiError trait form the client and changed it to recei…
sapessi f53bd30
Changed HandlerError type to alias Box<dyn Error> to allow the runtim…
sapessi 8b6d8fc
Added custom error examples and updated existing examples
sapessi 2e034d2
Fixed failure example
sapessi 4f20464
Updated comment on HandlerError type
sapessi d17b7c8
Exported HandlerError in root of the crate
sapessi 08772e9
Added error code to response structure and centralized backtrace gene…
sapessi a6d2c5b
Updated example in lib docs
sapessi fee02e8
Temporary fix for failure example
sapessi 4969624
Switched to HandlerError struct that can be created from any Display …
sapessi 0bce533
Addressed code review changes
sapessi bd3cb34
Changed error handling codes according to latest specs clarified in #23
sapessi 5b9bad9
Removed custom_attribute feature to fix build
sapessi 9ed9a43
Cleaned up lifetimes/borrows
sapessi 7fa1167
New runtime core crate that implements the runtime main loop and defi…
sapessi 5165242
Slimmed down runtime crate that only wraps the runtime core crate
sapessi 3bcb150
Rebased on master
sapessi ab54a2e
Moved HandlerError to error module for backward compatibility
sapessi 99b1328
Fixed error package in examples
sapessi 3844b43
Addressing CR on newline at the end of file and import grouping
sapessi fa2a5b1
More style changes from code review
sapessi b6423f7
Fixed tests, including http crate
sapessi 77459b5
First refactor of errors in the client crate and new errors crate
sapessi ecbae1c
Bump dependencies
sapessi 6896b1b
New derive crate (experimental) for LambdaErrorExt and new HandlerErr…
sapessi 3f79fcb
Switched back to ApiError and added new is_recoverable() method
sapessi 1b1e624
Parametrized error type and updated examples
sapessi 7de9169
Switched to more descriptive generic names
sapessi b991438
Added a new LambdaResultExt to simplify error handling in handlers
sapessi bedbf92
Added build script to generate the metadata file
sapessi e3f6b34
Changed the runtime client SDK to receive a user-agent as init param.…
sapessi 253a481
Fixed format of build.rs
sapessi db7f994
Fixed critical issue in runtime client - request URIs were not genera…
sapessi f0de223
Fixed code issue - committed to fast earlier
sapessi d705def
New error tests and failure featurs in Cargo. Still cannot get a back…
sapessi a3aaedb
failure features import
sapessi fd35180
Added doc comment on lambda! macro
sapessi 8827cdb
merge latest master changes
sapessi 32cd6e0
Fixed failure dep in Cargo (CR feedback)
sapessi 0f54490
Removed unnecesary test (CR feedback)
sapessi bb61d71
Another round of CR feedback
sapessi 6891eaa
Added comment to error header as per CR
sapessi ee12d37
Changed order of deps while cleaning up
sapessi 315c979
Removed commented code as per CR
sapessi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
/target | ||
/.cargo | ||
lambda-runtime/libtest.rmeta |
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
[workspace] | ||
members = [ | ||
"lambda-runtime-client", | ||
"lambda-runtime-core", | ||
"lambda-runtime", | ||
"lambda-http" | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.