Fix support for APIGW console requests #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test requests from the APIGW console don't include time epoch. This change makes that field to be deserialized with a default value in those cases. Signed-off-by: David Calavera <[email protected]>
bnusunny
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #655
Description of changes:
Test requests from the APIGW console don't include time epoch. This change makes that field to be deserialized with a default value in those cases.
I'm trying to just make minimal changes to this, but we should think about better ways to surface deserialization problems in http requests, maybe even writing our own deserializer, out of the scope for this PR.
By submitting this pull request