Skip to content

Improvements in event compilation #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 28, 2023
Merged

Improvements in event compilation #659

merged 5 commits into from
May 28, 2023

Conversation

calavera
Copy link
Contributor

@calavera calavera commented May 28, 2023 •
edited
Loading

Description of changes:

I made a compilation cleanup in the events crate to mark more dependencies as optional. With this changes, fresh projects that depend on lambda_http need 5 seconds less to compile because they need to compile less dependencies.

This is the list of changes:

  • Mark chrono, http, http-serde, http-body, bytes, and query_map as optional dependencies.
  • Remove 2015 idioms. For people new to Rust, those idioms are strange since nobody uses them anymore.
  • Remove implicit macro imports. Same as above.
  • update crate's edition to 2021. This matches the rest of packages in this repository.
  • Test features in isolation. To ensure that all event features work on their own and there are no compilation issues.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

calavera added 5 commits May 25, 2023 21:34
@calavera
Make compiling chrono conditional
5e7609d 
It's not necessary for all event types.

Signed-off-by: David Calavera <[email protected]>
@calavera
Make compiling query_map conditional.
e55d79f 
It's not used in all events.

Signed-off-by: David Calavera <[email protected]>
@calavera
Test individual features
e7b229a 
- Convert package to 2021 edition.
- Format imports.

Signed-off-by: David Calavera <[email protected]>
@calavera
Remove old idioms
7d57ad4 
So people don't have to learn 2015 idioms like `extern crate` and implicit macro imports.

Signed-off-by: David Calavera <[email protected]>
@calavera
Bump crate version
6be612a 
Signed-off-by: David Calavera <[email protected]>
@calavera calavera force-pushed the event_conditional_compilation branch from c8d2cc9 to 6be612a Compare May 28, 2023 02:06
@calavera calavera merged commit a7329a4 into main May 28, 2023
@calavera calavera deleted the event_conditional_compilation branch May 28, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnusunny bnusunny bnusunny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calavera @bnusunny