Fix APIGW path with stage #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APIGW HTTP has started adding the stage to the path in the event. This change checks if the stage is already a prefix in the path, and skips adding it if so. Signed-off-by: David Calavera <[email protected]>
There might be cases when you don't want the runtime to do anything with paths and stages. By setting AWS_LAMBDA_HTTP_IGNORE_STAGE_IN_PATH in the environment, we ignore this behavior completely. Signed-off-by: David Calavera <[email protected]>
calavera
force-pushed
the
fix_path_with_stage
branch
3 times, most recently
from
94a681e to
3127592
Compare
BMorinDrifter
approved these changes
Jun 29, 2023
| None => path.into(), | ||
| Some(stage) if stage == "$default" => path.into(), | ||
| Some(stage) => format!("/{stage}{path}"), | ||
| if env::var("AWS_LAMBDA_HTTP_IGNORE_STAGE_IN_PATH").is_ok() { |
There was a problem hiding this comment.
Should this be documented somewhere? Although looking through the docs I couldn't find an obvious home.
Otherwise LGTM!
There was a problem hiding this comment.
that's exactly why I didn't write any docs about it 😅
In theory, nobody should use this option, but who knows. The only case I could find for something like this is if your stage has a name, for example Prod, and you decide that the real path for your api also starts with /Prod. I've never seen something like this, but you never know.
bnusunny
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #668
Description of changes:
APIGW HTTP has started adding the stage to the path in the event. This change checks if the stage is already a prefix in the path, and skips adding it if so.
This also introduces an environment variable to skip this behavior completely because there might be cases where the user just wants the runtime to do nothing.
By submitting this pull request