Api Gateway authorizer improvements #827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the generic attribute since the authorizer values are not always of the same type, just use Value. - Match authorizer type to use the same type for all events. - Make the authorizer fields match the Java and DotNet implementation, which both use a Map<String, Object> for Rest and WebSocket events. -- https://github.com/aws/aws-lambda-dotnet/blob/master/Libraries/src/Amazon.Lambda.APIGatewayEvents/APIGatewayProxyRequest.cs -- https://github.com/aws/aws-lambda-java-libs/blob/main/aws-lambda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/APIGatewayV2WebSocketEvent.java#L225 Signed-off-by: David Calavera <[email protected]>
Signed-off-by :David Calavera <[email protected]>
This also shows how to work with the RequestExt trait and the RequestContext object. Signed-off-by: David Calavera <[email protected]>
Make the name more consistent since it's used for multiple versions of Api Gateway. Keep the old names as deprecated. Signed-off-by: David Calavera <[email protected]>
Signed-off-by: David Calavera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
The discussion in #823 made me think that we can provide much better ergonomics to work with Api Gateway Authorizers, since it looks like a common use case.
Description of changes:
There are changes in the events crate that are not backwards compatible, but I believe they provide much better user experience. I've divided this PR in three commits so you can check the changes out in isolation. There are more details in the commit messages.
By submitting this pull request