Skip to content

fix(integ tests): enable graceful-shutdown feature flag; chore(ci/cd): build integration test crate as part of PR validation #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

jlizen
Copy link
Contributor

@jlizen jlizen commented May 8, 2025

📬 Issue #, if available:
n/a

✍️ Description of changes:
#982 broke our integration test since it did not enable the new graceful-shutdown feature flag but used the new spawn_graceful_shutdown_handler(). Sorry about that, I missed fixing it when i removed graceful-shutdown from default features partway through the PR.

Sample failure: https://github.com/awslabs/aws-lambda-rust-runtime/actions/runs/14901777878/job/41855115960

I also included a github CI update to build the integ test crate on new PRs. That way we can catch this kind of regression prior to merge.

🔏 By submitting this pull request

  • [x ] I confirm that I've ran cargo +nightly fmt.
  • [ x] I confirm that I've ran cargo clippy --fix.
  • [x ] I confirm that I've made a best effort attempt to update all relevant documentation.
  • [x ] I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jlizen jlizen changed the title fix(integ tests): enable graceful-shutdown feature flag fix(integ tests): enable graceful-shutdown feature flag; chore(ci/cd): build integration test crate as part of PR validation May 8, 2025
@bnusunny bnusunny merged commit 56a23bf into awslabs:main May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants