Skip to content

chore(doc): update bedrock documentation #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 8, 2025
Merged

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Apr 8, 2025

Fixes #

  • split the existing Bedrock readme into multiple files
  • add documentation about some of the features missing from the current document

Missing:

  • creating a data source section wrong

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

dineshSajwan
dineshSajwan previously approved these changes Apr 8, 2025
Copy link
Contributor

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented Apr 8, 2025

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #1069 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@krokoko krokoko dismissed stale reviews from MichaelWalker-git and dineshSajwan via cee97e8 April 8, 2025 18:44
@krokoko krokoko enabled auto-merge (squash) April 8, 2025 19:53
Copy link
Contributor

@MichaelWalker-git MichaelWalker-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krokoko krokoko merged commit ce37948 into awslabs:main Apr 8, 2025
13 checks passed
@krokoko krokoko deleted the doc_bedrock branch April 11, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants