Skip to content

fix(logs): prevent shfmt environment variable deprecation warning #1227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

benelan
Copy link
Contributor

@benelan benelan commented Nov 19, 2024

Prevent consistent warnings in the log file about deprecated shfmt environment variables. The change also slightly improves performance by reducing the iterations.

Alternatively, I could check the shfmt object for environment variable usage instead of skipping them like logLevel. Let me know what you'd prefer!

Fixes #1226

Copy link
Collaborator

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@skovhus skovhus enabled auto-merge March 1, 2025 10:00
@skovhus skovhus merged commit af4b3ac into bash-lsp:main Mar 1, 2025
3 checks passed
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (5164c63) to head (c4cccaf).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1227      +/-   ##
==========================================
- Coverage   81.13%   80.91%   -0.23%     
==========================================
  Files          29       29              
  Lines        1442     1441       -1     
  Branches      343      344       +1     
==========================================
- Hits         1170     1166       -4     
- Misses        218      221       +3     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warrning: Environment variable configuration is being deprecated
2 participants