Skip to content

Remove python-dateutil and readerwriterlock dependencies #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

chrisrink10
Copy link
Member

@chrisrink10 chrisrink10 commented Aug 18, 2024

Remove some lightly used dependencies and replacing them with stdlib replacements:

  • python-dateutil was only used for parsing #inst "..." tags, which was already supported via datetime.datetime.fromisoformat, so removing it for now.
  • readerwriterlock was intended to be a reader-preferring lock for things like Atoms, but it's not been updated in some time and probably wasn't making much of a difference to begin with since Python still has a GIL.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loosen version constraints on some of these dependencies.

@chrisrink10 chrisrink10 marked this pull request as ready for review August 18, 2024 16:54
@chrisrink10 chrisrink10 merged commit cc1c6fc into main Aug 18, 2024
12 checks passed
@chrisrink10 chrisrink10 deleted the cleanup/remove-unnecessary-dependencies branch August 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant