Skip to content

Add read-all function #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 21, 2024
Merged

Add read-all function #986

merged 4 commits into from
Aug 21, 2024

Conversation

mitch-kyle
Copy link
Contributor

Emerged from #979

chrisrink10
chrisrink10 reviewed Aug 21, 2024
View reviewed changes
Copy link
Member

@chrisrink10 chrisrink10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for breaking these out from the other PR. One very minor nit.

@chrisrink10 chrisrink10 merged commit beee96a into basilisp-lang:main Aug 21, 2024
12 checks passed
This was referenced Aug 24, 2024
Merged
Closed
@mitch-kyle mitch-kyle mentioned this pull request Aug 25, 2024
Merged
chrisrink10 pushed a commit that referenced this pull request Aug 25, 2024
@mitch-kyle
Use *default-data-reader-fn* when calling core read functions #924 (#…
4f5e6c6 
…1001)

This is an amendment for #979. 

This was missed when merging back #986 after it was separated out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrink10 chrisrink10 chrisrink10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mitch-kyle @chrisrink10