keyword function return default in error cases

[mitch-kyle]

Fixes #997

Quick fix. I noticed that using a keyword as a function with nil as the collection always returns nil rather than the default.

This demonstrates the bug:

(:foo nil :bar)

;; Expected 
=> :bar

;;Actual
=> nil

[mitch-kyle]

Looks like the failure was with storing the test result rather than the test itself.

[chrisrink10]

I had no idea Clojure just let any value pass here. Yuck. But thanks for catching this. Two very minor comments on the changelog.

[chrisrink10]

Can you undo this removal?

[chrisrink10]

Can you file a ticket w/ the issue and use that as the reference here?

[mitch-kyle]

sure

[chrisrink10]

Looks like the failure was with storing the test result rather than the test itself.

These seem to be transient. I reran it and it was fine.

[mitch-kyle]

I had no idea Clojure just let any value pass here. Yuck.

In scheme, nil is the empty list. This behaviour is carried over to Clojure. If you do (assoc nil :a 1) you get {:a 1}; it's the same line of thinking.

[mitch-kyle]

Comments have been addressed, I'm not what's happening with the readthedocs build and it doesn't look like I have the power to retry it

[chrisrink10]

I had no idea Clojure just let any value pass here. Yuck.

In scheme, nil is the empty list. This behaviour is carried over to Clojure. If you do (assoc nil :a 1) you get {:a 1}; it's the same line of thinking.

I am not referring to nil. Your change allows keywords to respond to any value and simply ignore it. Clojure seems to allow the same:

user=> (:kw 3 :default)
:default
user=> (:kw "hi" :default)
:default
user=> (:kw "hi")
nil

[chrisrink10]

Comments have been addressed, I'm not what's happening with the readthedocs build and it doesn't look like I have the power to retry it

Looks like another transient failure. I reran and it was fine.