tests: make toolchain tests run in the same build instead of bazel-in-bazel integration tests #2095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, CI Should be happy now. @aignas Do we happen to have existing code to map the Over in tests/toolchains/defs.bzl, I'm generating a target for each version. However, not all versions support all platforms, e.g., 3.8.10 doesn't support windows. So I need to generate e.g. That config setting generation looks awfully familiar, as do the platform 2-tuple strings (e.g. "aarch64-apple-darwin", "x86_64-unknown-linux-gnu"). |
aignas
reviewed
Aug 1, 2024
| dev_dependency = True, | ||
| ) | ||
| dev_python.rules_python_private_testing( | ||
| register_all_versions = True, |
There was a problem hiding this comment.
Something like this could be super useful in registering minor_major versions by default.
There was a problem hiding this comment.
Yeah, I had a similar thought. I'll post in slack.
aignas
added a commit
to aignas/rules_python
that referenced
this pull request
Aug 1, 2024
aignas
reviewed
Aug 1, 2024
| break | ||
| if register_all: | ||
| arg_structs.extend([ | ||
| _create_toolchain_attrs_struct(python_version = v) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 2, 2024
This PR uses the `flag_values` from the platform definitions for the toolchains so that in the future we can distinguish between `musl` and `glibc` toolchains in our tests. For now the change is no-op. As part of this change we are also registering the coverage tools so that we can run `bazel coverage` with no errors. See comment on #2095.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the //tests/toolchains tests to run in the same Bazel build instance instead of
being bazel-in-bazel integration tests. This is done by using a transition to set
the python version to match the desired toolchain.
This makes running the tests much cheaper -- there were 37 sub-bazel processes being
started (one for each python version), which was very expensive. Debugging is also much easier because they aren't part of a bazel-in-bazel invocation.