fix: declare PyInfo as provided by test/binary/library #2777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
changed the title
|
This mostly LGTM. The one thing to do is update the changelog. I renamed this to fix instead of feature. They should have always been declared. |
aignas
reviewed
Apr 15, 2025
rickeylev
approved these changes
Apr 20, 2025
|
@rickeylev Thank you for pushing this over the line. I planned to do it today, and it seems you did all the remaining work 👏 🙇 |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the rules don't advertise the PyInfo provider through the provides argument
to the rule function. This means that aspects that want to consume PyInfo can't use
required_providersto restrict themselves to the Python rules, and instead have toapply to all rules.
To fix, add PyInfo to the provides arg of the rules.
Fixes #2506