Skip to content

feat: Have pip_compile generate a *.test target; deprecate *_test #2812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 23, 2025

Conversation

dougthor42
Copy link
Collaborator

Fixes #2794.

The pip_compile macro generates *_test and *.update targets. This
pattern does not match with other macros that generate similar targets,
namely gazelle_python_manifest and uv lock (though that's .run
instead of .test but either way, it uses a dot . instead of underscore
_).

Adjust the macro so that a .test target is made. The _test target is
aliased with a deprecation warning, to be removed in the next major
version.

@dougthor42 dougthor42 changed the title feat: Have pip_compile generate a *.test target feat: Have pip_compile generate a *.test target Apr 22, 2025
@dougthor42 dougthor42 changed the title feat: Have pip_compile generate a *.test target feat: Have pip_compile generate a *.test target; deprecate *_test Apr 22, 2025
@dougthor42 dougthor42 marked this pull request as ready for review April 23, 2025 02:55
@dougthor42 dougthor42 enabled auto-merge April 23, 2025 20:47
@dougthor42 dougthor42 added this pull request to the merge queue Apr 23, 2025
Merged via the queue into bazel-contrib:main with commit b7e58d1 Apr 23, 2025
3 checks passed
@dougthor42 dougthor42 deleted the u/dthor/sync-dot-gh2794 branch April 23, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconcile _test and .test in macros
2 participants