Use worker proto from @bazel_tools #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sigh, CI is red because this tickles bazelbuild/bazel#12963 which was fixed in bazelbuild/bazel@463e8c8 which will be in 5.0 but not any 4.x release. I guess we could maybe merge this when 5.x lands? |
This would force everyone to upgrade to Bazel 5, I guess we will have to wait a bit more. |
|
@illicitonion we are on Bazel 6, would you be interested to rebase on your changes on current master? |
This avoids needing to vendor our own copy.
illicitonion
force-pushed
the
unvendor-proto
branch
from
b478afd to
4eec35e
Compare
|
Rebased - thanks so much! |
liucijus
approved these changes
Feb 1, 2024
simuons
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids needing to vendor our own copy.