Implement diagnostics for Scala 3 (#1602) #1610
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
susliko
commented
Sep 4, 2024
| //Invokes Scala 3 compiler | ||
| class ScalacInvoker{ | ||
| // Invokes Scala 3 compiler | ||
| class ScalacInvoker { |
There was a problem hiding this comment.
PR is draft since it lacks tests.
Any tips on setting up diagnostic tests for Scala 3 would be great.
susliko
force-pushed
the
scala3-diagnostics
branch
from
c9ddc80 to
38a14f2
Compare
|
Closing in favor of #1611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1602.
This PR implements
ProtoReporterfor Scala 3 compiler and makes use of it in a correspondingScalacInvoker.Motivation
Get error-highlighting working in Bazel projects with Scala 3 for editors using Metals