Port DependencyAnalyzer plugin to Scala 3 #1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simuons
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Thanks, @WojciechMazur, for taking this long standing issue.
Please take a look at one minor comment and also please resolve conflict.
Overall all looks good. Thanks.
| @@ -114,6 +115,8 @@ class AstUsedJarFinderTest extends AnyFunSuite { | |||
|
|
|||
| expectedUnusedDeps.foreach { dep => | |||
| val expectedError = s"Target '$dep' is specified as a dependency to ${TestUtil.defaultTarget} but isn't used, please remove it from the deps." | |||
| println(errors) | |||
There was a problem hiding this comment.
These were only used when debugging, I forgot to remove them. Fixed now
…n compiling under Scala 3.1.3 (fixed in 3.2)
…angerous counterpart
… by Scala 3.1.3 is JDK 18
WojciechMazur
force-pushed
the
scala3/dependency-analyzer
branch
from
366f94a to
779d02a
Compare
simuons
approved these changes
Nov 8, 2024
liucijus
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dangerous_test_thirdparty_version.sh- old script is no longer working, the applied patches are no longer applicable, thus always using the default version for given major Scala versionMotivation
Feature parity between Scala 2 and Scala 3 support. It's probably the last missing (major) piece.