Added CI for single toolchain channel workspaces #1712
Conversation
UebelAndre
force-pushed
the
nightly
branch
7 times, most recently
from
2e47e8c to
ce0be42
Compare
UebelAndre
force-pushed
the
nightly
branch
3 times, most recently
from
4d0d1a4 to
c370382
Compare
UebelAndre
changed the title
| @@ -68,8 +68,7 @@ mod test { | |||
| ]); | |||
| assert!( | |||
| !out_content.contains("should not be in output"), | |||
| "output should not contain 'should not be in output' but did: {}", | |||
| out_content | |||
| "output should not contain 'should not be in output' but did", | |||
There was a problem hiding this comment.
I believe this change is related to rust-lang/rust-clippy#10055
Unfortunately #[allow(clippy::uninlined_format_args] cannot be used here without requiring we raise our min supported Rust version above 1.59.0
There was a problem hiding this comment.
Can rustversion::attr be used here? https://crates.io/crates/rustversion
(I don't know the answer - I know rustversion can be used for conditional attrs on structs, and can't be used for conditional enabling of features - I'm not sure how allows fit in :))
There was a problem hiding this comment.
I don't think it'd be appropriate to add a new external dependency just for this. It seems it'll be fixed in a future nightly release so I think it's an acceptable trade off for now. If I can remember it I'll add them back in the future
| #[test] | ||
| pub fn test_tool_exec() { | ||
| let tool_path = env!("TOOL_PATH"); | ||
| assert!( | ||
| tool_path.contains("-exec-"), | ||
| "tool_path did not contain '-exec-': {}", | ||
| tool_path | ||
| "tool_path did not contain '-exec-'", |
There was a problem hiding this comment.
Same as #1712 (comment)
This provides regression testing for cases where users have only registered one toolchain in their workspace (meaning they only have a toolchain of a single channel type).