Skip to content
This repository was archived by the owner on Mar 8, 2020. It is now read-only.

JSX languages are not part of the JavaScript driver #46

Closed
bzz opened this issue Nov 29, 2018 · 2 comments · Fixed by #84
Closed

JSX languages are not part of the JavaScript driver #46

bzz opened this issue Nov 29, 2018 · 2 comments · Fixed by #84

Comments

@bzz
Copy link
Contributor

bzz commented Nov 29, 2018

This is analogy of bblfsh/bash-driver#39 and thus, although it's not a driver issue per-say, it is still logged here.

It arouse from trying to reproduce #42:

Parsing a JSX file using bblfshd go client client.NewParseRequest().ReadFile("source.js.jsx").UAST() results in panic: rpc error: code = Unknown desc = unexpected error: runtime failure: missing driver for language "jsx"

General solution is proposed in bblfsh/bash-driver#39 (comment) (will be moved to SDK issue soon)

@bzz
Copy link
Contributor Author

bzz commented Nov 29, 2018

Initially, this issue was about JSON support

From https://www.json.org/

It is based on a subset of the JavaScript Programming Language, Standard ECMA-262 3rd Edition - December 1999

But https://stackoverflow.com/questions/23752156/are-all-json-objects-also-valid-javascript-objects
explains the details of a case where JSON may not be a valid JavaScript 😢 and thus we might need to either have a JSON driver, or figure out right bable extension + add it to language_aliases.

@bzz
Copy link
Contributor Author

bzz commented Nov 29, 2018

Keeping this open, as current driver does already support language extensions like jsx.

It does have the same problem as JSON, initially described in here - detected by enry as different languages, they would not be routed to JavaScript drivers with

panic: rpc error: code = Unknown desc = unexpected error: runtime failure: missing driver for language "jsx"

Updated title and description to mention both JSX and JSON.

@bzz bzz changed the title JSON language is not part of the JavaScript driver JSX language is not part of the JavaScript driver Nov 29, 2018
@bzz bzz changed the title JSX language is not part of the JavaScript driver JSX/JSON languages are not part of the JavaScript driver Nov 29, 2018
@bzz bzz mentioned this issue Nov 29, 2018
@bzz bzz changed the title JSX/JSON languages are not part of the JavaScript driver JSX languages are not part of the JavaScript driver May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant