This repository was archived by the owner on Mar 8, 2020. It is now read-only.
Enable language aliases #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creachadair
approved these changes
May 24, 2019
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @bzz)
Signed-off-by: Denys Smirnov <[email protected]>
bzz
reviewed
May 28, 2019
| github.com/golang/protobuf v1.2.0 h1:P3YflyNX/ehuJFLhxviNdFxQPkGK5cDcApsge1SqnvM= | ||
| github.com/golang/protobuf v1.2.0/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U= | ||
| github.com/golang/protobuf v1.3.1 h1:YF8+flBXS5eO826T4nzqPrxfhQThhXl0YzfuUPu4SBg= | ||
| github.com/golang/protobuf v1.3.1/go.mod h1:6lQm79b+lXiMfvg/cZm0SGofjICqVBUtrP5yJMmIC1U= |
There was a problem hiding this comment.
Does 2 versions of protobuf are still there after go mod tidy?
There was a problem hiding this comment.
Yeah, it seems like it tries to preserve at least two versions in go.sum in case we decide to rollback.
Note that go.sum is not a lock file in the regular sense. It does lock versions, but it does this for all current and previous dependencies to guarantee a safe rollback to most previous dep versions (possibly only major ones + one minor).
bzz
reviewed
May 28, 2019
bzz
approved these changes
May 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update SDK, Go version and enable language aliases.
Addresses src-d/gitbase#728
Fixes #46
Signed-off-by: Denys Smirnov [email protected]
This change is