Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't shade the email-rfc2822-validator dependency anymore #122

Closed
CodeMason opened this issue Jan 1, 2018 · 2 comments
Closed

Don't shade the email-rfc2822-validator dependency anymore #122

CodeMason opened this issue Jan 1, 2018 · 2 comments
Assignees
@bbottema
Labels
enhancement Priority-Low
Milestone
5.0.0

Comments

@CodeMason
Copy link

The entire package, org.hazlewood.connor.bottema.emailaddress.simplejavamail doesn't exist in the latest 5.0RC sources.

If one downloads the sources from https://github.com/bbottema/email-rfc2822-validator, the source for EmailAddressValidator doesn't match the decompiled classes from simple-java-mail.

Of note, the package is also different between the two projects.
@bbottema
Copy link
Owner

bbottema commented Jan 2, 2018 •
edited
Loading

This is by design. To avoid maven dependencies on micro-libraries, email-rfc2822-validator is being shaded into the resulting jar (under a modified package to avoid collisions). This is possible, because that library is managed by myself as well.

Similarly DKIM was included as well before 5.0.0.rc1, but because it is an external library, it is not included in the simple-java-mail JAR.

@bbottema bbottema closed this as completed Jan 2, 2018
@bbottema
Copy link
Owner

bbottema commented Jan 2, 2018

I am considering turning it into a proper dependency as well, though. Thanks for refreshing my memory.

@bbottema bbottema reopened this Jan 2, 2018
bbottema added a commit that referenced this issue Feb 14, 2018
@bbottema
#122 switched to email-rfc2822-validator as a proper Maven dependency…
4b6da3e 
… rather than a shaded library that is included in the simple-java-mail jar
@bbottema bbottema self-assigned this Feb 14, 2018
@bbottema bbottema added this to the 5.0.0 milestone Feb 14, 2018
@bbottema bbottema changed the title Source not included in maven release for email validation Don't shade the email-rfc2822-validator dependency anymore Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbottema bbottema

Labels
enhancement Priority-Low
Projects
None yet
Milestone
5.0.0
Development

No branches or pull requests
2 participants
@bbottema @CodeMason