Skip to content

[Enhancement] reduce log spam from the batch-module #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
InteractiveNinja opened this issue Sep 12, 2024 · 3 comments
Closed

[Enhancement] reduce log spam from the batch-module #543

InteractiveNinja opened this issue Sep 12, 2024 · 3 comments

Comments

@InteractiveNinja
Copy link

Hello 👋

Firstly, thanks for maintaining this library.

I noticed that when I upgraded to >=v8.11.1, the logs are getting flooded with messages when I run the backend server locally.
I found out that the log statement is from bbottema/generic-object-pool#8, which is used in #529.

15:44:01.147 [pool-1-thread-2|org.bbottema.genericobjectpool.GenericObjectPool]                                                       DEBUG - 0 objects invalidated as per expiration policy!
15:44:01.157 [pool-1-thread-2|org.bbottema.genericobjectpool.GenericObjectPool]                                                       DEBUG - 0 objects invalidated as per expiration policy!
15:44:01.167 [pool-1-thread-2|org.bbottema.genericobjectpool.GenericObjectPool]                                                       DEBUG - 0 objects invalidated as per expiration policy!
15:44:01.177 [pool-1-thread-2|org.bbottema.genericobjectpool.GenericObjectPool]                                                       DEBUG - 0 objects invalidated as per expiration policy!
15:44:01.188 [pool-1-thread-2|org.bbottema.genericobjectpool.GenericObjectPool]                                                       DEBUG - 0 objects invalidated as per expiration policy!
15:44:01.198 [pool-1-thread-2|org.bbottema.genericobjectpool.GenericObjectPool]                                                       DEBUG - 0 objects invalidated as per expiration policy!

I don't think there's anything I need to change to stop the log statements without removing the logging for this library in my project.

I appreciate your time 👍

@bbottema
Copy link
Owner

Well, I think it's good to tweak it so it only logs if there are actual objects invalidated and also perhaps make it TRACE level. Having said that, wouldn't it make sense for you to set the debug level to INFO for org.bbottema.genericobjectpool?

@bbottema bbottema changed the title Spammed debug statements "objects invalidated as per expiration policy!" [Enhancement] reduce log spam from the batch-module Sep 15, 2024
@bbottema
Copy link
Owner

Released tweak in 8.11.3

@bbottema bbottema added this to the 8.11.3 milestone Sep 16, 2024
@InteractiveNinja
Copy link
Author

Thank you kindly for the fast change 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants