-
Notifications
You must be signed in to change notification settings - Fork 408
Add ts enums #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add ts enums #15
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
f16fabc
Adding support for ts enums; added tsEnumNames to schema
2c078b1
Exporting ts enum types if exporting is enabled
b68a46c
Adding internal publication
027fd59
Improved ts enum support for inline enums
effc663
Bumping version; updating tests
8ddda5e
Adding file ref test
01b732b
Undoing publish change
a8dbf36
Merging master
99476e2
Remove todo that was fixed
723cdd1
v1.2.3: add generated typescript helpers
752f60d
Adding util class generation for enums
f992eea
Bug
929ee8e
Commit dist
dc38627
Fix toStringValue generated method
80fbb6d
Lint
5672557
Merging master
ce84a4b
Bad quote! Bad!
4174c1f
Adding enum validation/error case tests
b27d7fe
Add ability to generate const enums
d08da0a
Fix lint
a155061
Merging master
f024314
Moving enum utils; removing setting for using ts enums; using ts enum…
c40f07f
Removing enum utils
b8f50a3
Last round of code review feedback
6eca6d0
Fixing tests
0895054
Updating dist
108147b
Default to const enums
392695f
Update dist
523eec7
Remove propagation logic now that EnumValue is only used for int enums
d3abd8c
Dist
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
{ | ||
"version": "0.2.5", | ||
"configurations": [ | ||
{ | ||
// Name of configuration; appears in the launch configuration drop down menu. | ||
"name": "Run mocha", | ||
// Type of configuration. Possible values: "node", "mono". | ||
"type": "node", | ||
// Workspace relative or absolute path to the program. | ||
"program": "${workspaceRoot}/node_modules/mocha/bin/_mocha", | ||
// Automatically stop program after launch. | ||
"stopOnEntry": false, | ||
// Command line arguments passed to the program. | ||
"args": ["out/test/test.js"], | ||
// Workspace relative or absolute path to the working directory of the program being debugged. Default is the current workspace. | ||
"cwd": "${workspaceRoot}", | ||
// Workspace relative or absolute path to the runtime executable to be used. Default is the runtime executable on the PATH. | ||
"runtimeExecutable": null, | ||
// Environment variables passed to the program. | ||
"env": { "NODE_ENV": "production"} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't check this in, I don't use this setup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setup doesn't use anything environment-specific. It's generalizable so long as we use mocha, so if someone writes TS in vscode, this run configuration can save them the work of figuring out how to debug tests. I think it adds value, but obviously it's your project so I'll remove it if you still think I should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean. Also I realized that .vscode/settings is already checked in - let's keep this guy here :)