Skip to content

Add q2str to convert quaternion to string #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

petercorke
Copy link
Collaborator

Add q2str() to convert a quaternion to a string, replacing old functionality of qprint(..., file=None) which is unintuitive. Added deprecation notice to qprint if this type of call is invoked, but file can be set to any valid file-like object reference.

Tests and doco provided.

…ity of `qprint(..., file=None)` which is unintuitive. Added deprecation notice to `qprint`, tests and doco.
@petercorke petercorke added the enhancement New feature or request label Jan 21, 2025

By default the string is written to `sys.stdout`.

If `file=None` then a string is returned.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line in the doc-string is from a previous version of your code; I don't see a file argument.

Copy link
Collaborator

@myeatman-bdai myeatman-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@myeatman-bdai myeatman-bdai merged commit a08f25e into bdaiinstitute:master Jan 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants