-
Notifications
You must be signed in to change notification settings - Fork 1
Runners framework #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y for results and context, and add SpawnProcessRunner that copies context and needed results into subprocess
…rove performance when a worker can directly add to results_map)
…ts depending on whether tasks are cached or not, and it will complicate or constrain optimisation of result memory management.
…ds are not compatible with process forking.
…n loading tasks from cache
…1 - a lab with max_workers=1 can be used.
Notes from development:
Plan:
|
72a5c06
to
7b6b5ba
Compare
…ear cache between tests
…t correct timings.
… via queue will be a different identity)
…ailure, and raise original keyboard interrupts.
… never waits for processes to finish.
…a thread to avoid race conditions on keyboard interrupt.
cbe2b33
to
c9f6895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RunnerBackend
classes that can implement different strategies for executing tasks (laying the groundwork for distributed task execution with Ray)spawn
andfork
backends to cover existing process-based execution paradigms.concurrent.futures
, which made use of threading that required all subprocesses to be forked up front before any task execution. By no longer relyingconcurrent.futures
, thefork
backend can use shared/forked memory to share the results of earlier tasks with later tasks. Also, thefork
backend now implicitly uses shared memory to share task context with subprocesses.TaskDiedError
when keyboard-interrupting a fork runner.runner_backend='serial'
instead of implicitly switching to serial processing whenmax_workers=1
#31