Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Instead of using integer 0 (zero) for
char *
,FILE *
, and function argument (setvbuf
), mentioningnullptr
seems reasonable for C++. Since in C,NULL
is defined as(void *)0
, which I assume should be similar to C++ too, this explicitly removes the warning which can be viewed by the-Wzero-as-null-pointer-constant
parameter for both, GCC and Clang.