feat: parse SQL statement types with node-sql-parser instead of rely on the first token. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing only the first token We used to rely on the first token of the SQL query (e.g., “SELECT”, “UPDATE”) to decide whether it was a read or write query. This was prone to errors when queries started with non-standard tokens or subqueries. By using node-sql-parser, we now inspect the actual AST and accurately detect statement types such as SELECT, INSERT, UPDATE, DELETE, etc. This approach is more reliable and reduces false positives.
|
Love it, thank you for this. |
|
wow that was fast! |
|
Tested and working locally. Released at v1.0.21 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server used to rely on the first token of the SQL query (e.g., “SELECT”, “UPDATE”) to decide whether it was a read or write query. This was prone to errors when queries started with non-standard tokens or subqueries. By using node-sql-parser, we now inspect the actual AST and accurately detect statement types such as SELECT, INSERT, UPDATE, DELETE, etc. This approach is more reliable and reduces false positives.