AttributeError when running gunicorn over HTTPS

[doriand01]

When running gunicorn with my certificate and keyfile over https, sending any request to the server gives me this error.

Traceback (most recent call last):
  File "/opt/bitnami/python/lib/python2.7/site-packages/gunicorn/arbiter.py", line 515, in spawn_worker
    worker.init_process()
  File "/opt/bitnami/python/lib/python2.7/site-packages/gunicorn/workers/base.py", line 126, in init_process
    self.run()
  File "/opt/bitnami/python/lib/python2.7/site-packages/gunicorn/workers/sync.py", line 119, in run
    self.run_for_one(timeout)
  File "/opt/bitnami/python/lib/python2.7/site-packages/gunicorn/workers/sync.py", line 66, in run_for_one
    self.accept(listener)
  File "/opt/bitnami/python/lib/python2.7/site-packages/gunicorn/workers/sync.py", line 30, in accept
    self.handle(listener, client, addr)
  File "/opt/bitnami/python/lib/python2.7/site-packages/gunicorn/workers/sync.py", line 141, in handle
    self.handle_error(req, client, addr, e)
  File "/opt/bitnami/python/lib/python2.7/site-packages/gunicorn/workers/base.py", line 213, in handle_error
    self.log.exception("Error handling request %s", req.uri)
AttributeError: 'NoneType' object has no attribute 'uri'

[benoitc]

Hi, thanks for the ticket! I don't reproduce it right now, can you give more detail?

how can I reproduce it? Which versions of Gunicorn are you running?

[doriand01]

I'm using 19.4.3. I ran it using the --certfile arguments and the --keyfile arguments, and provided an SSL Certificate and keyfile. However, whenever attempting to send a request, I simply get the above error.

[tilgovi]

This traceback appears when a client attempts to connect via HTTP (not HTTPS).

[tilgovi]

Either we can catch the SSLError in the base class handle_error:

diff --git a/gunicorn/workers/base.py b/gunicorn/workers/base.py
index 9ba8e75..488c2ea 100644
--- a/gunicorn/workers/base.py
+++ b/gunicorn/workers/base.py
@@ -10,6 +10,7 @@ import sys
 import time
 import traceback
 from random import randint
+from ssl import SSLError


 from gunicorn import util
@@ -181,7 +182,8 @@ class Worker(object):
         if isinstance(exc, (InvalidRequestLine, InvalidRequestMethod,
                 InvalidHTTPVersion, InvalidHeader, InvalidHeaderName,
                 LimitRequestLine, LimitRequestHeaders,
-                InvalidProxyLine, ForbiddenProxyRequest)):
+                InvalidProxyLine, ForbiddenProxyRequest,
+                SSLError)):

             status_int = 400
             reason = "Bad Request"

Or we should maybe move/change the line that depends on req.uri for logging the exception in the corresponding else clause.

This is a little verbose, even for debug, maybe:

[2016-01-07 13:25:43 +0000] [16469] [DEBUG] Error processing SSL request.
[2016-01-07 13:25:43 +0000] [16469] [DEBUG] Invalid request from ip=127.0.0.1: [SSL: WRONG_VERSION_NUMBER] wrong version number (_ssl.c:1752)
[2016-01-07 13:25:43 +0000] [16469] [DEBUG] Failed to send error message.

[benoitc]

@tilgovi the second solution is more explicit, isn't it?

[tilgovi]

@benoitc which? You mean moving the req.uri logging? I think I like that better.