-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain argv + fds on re-exec, fix USR2 under systemd by notifying new PID #3285
Open
pajod
wants to merge
10
commits into
benoitc:master
Choose a base branch
from
pajod:patch-systemd
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pajod
commented
Aug 27, 2024
This reverts dup-ing the socket fds on re-exec (and --bind=fd://3, and systemd socket activation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops mangling sys.argv and socket fd numbers on re-exec, thus permitting much improved integration with systemd.
-m
switch is the recommended procedure, so that should workNew feature: send timestamp to properly synchronize reload cycles using
Type=notify-reload
(systemd>= v253
)Fixes: module invocation breaks USR2 upgrading, as modified argv results in modified path #3281
Fixes: more status to systemd #1948
Fixes: Compatibility of systemd with zero downtime reloads with SIGUSR2 #2856
systemctl -s USR2 gunicorn.service
now automatically issues graceful quitsystemctl reload gunicorn.service
andsystemctl restart gunicorn.service
unchanged in .service exampleImproves systemd-specific case of: Error instead of warning in logs when sending SIGTERM since v21 #3050
Improves sock fd leak pointed out in: fd leak in thread worker causing periodic outages #3339
Follow-Up plans not included here:
< 3.10
and Python>= 3.10
BARRIER=1
so reloading/re-execing in quick success is reliable as wellEXTEND_TIMEOUT_USEC=
so automatic timeouts are reliable as well