Add Dockerfile for binary-com's standard perl image #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly derived from https://github.com/tm604/perl-docker with a few changes: - Use https://hub.docker.com/_/perl instead of building from debian:buster; this allows for source verification of both the Perl build and cpanm (which is already done on the official images) and a slightly slimmer build. - Forgo multi-stage build in favor of a smarter single-stage: we're due to install further dependencies on a later build trigger for derivative images anyway, so some core build essentials can be included here now for a batteries-included approach with less moving parts during the subsequent build triggers. - Add a sane `ENTRYPOINT` for correct behaviors when running on Kubernetes.
zakame
force-pushed
the
docker/standard-perl-image
branch
from
7beccbf to
1d6d4ef
Compare
- Add support for using an apt cache/proxy during builds. - Rebase against debian:buster; we'd want to build our own perl that we can supply our own configuration flags in the future. - Since we build our own perl (and cpanm) ensure we're doing some basic source validation for the tarballs; embed the SHA256 sums for now, figure a better way later.
tom-binary
reviewed
Jun 30, 2020
tom-binary
reviewed
Jun 30, 2020
| && cd App-cpanminus-1.7044 && /opt/perl-5.32.0/bin/perl bin/cpanm . \ | ||
| && rm -rf /var/lib/apt/lists/* /var/cache/apt/* \ | ||
| && rm -fr ./cpanm /root/.cpanm /usr/src/perl /usr/src/App-cpanminus-1.7044* /tmp/* \ | ||
| # Locale support is probably quite useful in some cases, but |
There was a problem hiding this comment.
Still unsure whether we should keep this - clean Unicode handling is an important feature, so maybe we should enforce a .UTF-8 locale by default...?
There was a problem hiding this comment.
Maybe, though with the current debian:buster base we already fall back to a C.UTF_8 locale:
root@558bed5a8132:/app# locale -a
C
C.UTF-8
POSIX
root@558bed5a8132:/app# ls /usr/lib/locale/
C.UTF-8
root@558bed5a8132:/app# locale
LANG=
LANGUAGE=
LC_ALL=
When using https://github.com/nektos/act for running tests locally, one can supply `$DEBIAN_PROXY` in .env file for act to use upon building the image. Also change the image name for consistency with Binary -> Deriv rebranding.
Use our DERIV author name on CPAN, and move perl/cpanm version info and checksums into environment variables for easy updating later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly derived from https://github.com/tm604/perl-docker with a
few changes:
Use https://hub.docker.com/_/perl instead of building fromBuild our own perl on top ofdebian:buster; this allows for source verification of both the Perl
build and cpanm (which is already done on the official images) and a
slightly slimmer build.
https://hub.docker.com/_/debian buster.
Forgo multi-stage build in favor of a smarter single-stage: we're due
to install further dependencies on a later build trigger for
derivative images anyway, so some core build essentials can be
included here now for a batteries-included approach with less moving
parts during the subsequent build triggers.
Add a sane
ENTRYPOINTfor correct behaviors when running onKubernetes.