Perl Image followups #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also serves as a very simple example of using our base perl image.
- Check aptfile for readability, not size, so it can be skipped if the file doesn't exist. - Do not auto-remove removable packages; removing them doesn't affect the overall image size anyway, and some packages (like runtime libraries auto-installed by their -dev counterparts) can be inadventently removed and break CPAN modules.
This probably needs its own workflow later, but for now just do a quick build and check using the dzil image.
This is important for cross-compile builds (e.g. amd64 to arm64) as cpanm/perl won't handle signals without defining them in the code, cf Perl/docker-perl#44. Without this, cross-compiles will appear to stall.
tom-binary
reviewed
Aug 4, 2020
| apt-get -y -q update \ | ||
| && apt-get -y -q --no-install-recommends install $(cat /app/aptfile); \ | ||
| fi \ | ||
| && cpanm --notest --quiet --installdeps --with-recommends . \ | ||
| && /usr/bin/dumb-init -- cpanm --notest --quiet --installdeps --with-recommends . \ |
There was a problem hiding this comment.
Why specifically cpanm requiring this? If it's a problem there, it'd be a problem everywhere, even apt install tends to run Perl code.
There was a problem hiding this comment.
I'm not sure if its even a Perl-only problem, as the case for this stems from cpanm subprocs like make/gcc/cc1 becoming zombies for some reason (hinting that some sub-parent is not handling signals,) and furthermore it doesn't happen on all cpanm installs. I agree that this might be placed further up in this RUN for the best coverage.
zakame
force-pushed
the
docker/perl-image-followups
branch
from
4751956 to
b938d13
Compare
Remove this regardless of DEBIAN_PROXY being set or not.
|
Combined these changes with some other fixes in #3, so this can be closed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deriv/perl)