-
Notifications
You must be signed in to change notification settings - Fork 392
chore: remove bdk_wallet and update readme and ci workflow #1928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove bdk_wallet and update readme and ci workflow #1928
Conversation
eefc1f9
to
1d7ad31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1d7ad31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run the cargo test
command, couple functions are failing.
@AmosOO7 running |
@luisschwa yes I did that. |
Can you show the errors? |
failures: test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 17.89s error: test failed, to rerun pass |
This test passes for me. Can you show the full log? |
I also noticed the test flags different functions, I don't know why that is happening. |
If you take a look at this log, it flags another function |
Hello @luisschwab and @notmandatory, I cloned the repo afresh, checked out the PR, compiled it, and ran cargo test, but I keep encountering errors. Could you please share the steps you used for testing? I’d like to compare and see if I might be missing something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1d7ad31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1d7ad31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1d7ad31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 1d7ad31
Description
Removes the
bdk_wallet
crate from the workspace of this repo now that it's been moved to it's own repo.Notes to the reviewers
I did a bit of extra cleanup on the README file. I replaced the crates list with a table that also includes badges for the crate version and docs. I also renamed the
example-crates
folder to simplyexamples
, a nit of mine that I already fixed in the newbdk_wallet
repo.See: bitcoindevkit/bdk_wallet#18
Changelog notice
For the changelog for the next version of
bdk_wallet
:bdk_wallet
crate has been removed from thebdk
repository and move to it's ownbdk_wallet
repository.Checklists
All Submissions:
cargo fmt
andcargo clippy
before committing