-
Notifications
You must be signed in to change notification settings - Fork 56
chore(deps): update reqwest
to 0.12
#118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update reqwest
to 0.12
#118
Conversation
Pull Request Test Coverage Report for Build 13823581735Details
💛 - Coveralls |
7ce1e08
to
e624151
Compare
Update: |
e624151
to
2b0cd90
Compare
Finally buckled down and got everything building w/ 1.63 locally.
|
@phlip9 Thanks for looking into it, I'll try to get things working on my end as well |
Ahh looks like some dev-dependencies also need to be pinned... |
2b0cd90
to
d84d8d0
Compare
Pinned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK d84d8d0
Updating to LDK 0.1, I noticed
esplora-client
is the last dep we have usingreqwest-v0.11
, which forces us to hold on to a ton of duplicate, old deps in our tree (http 0.2, hyper 0.14, rustls 0.21, ...). Updatingreqwest
to0.12
removes all these for us.I've also updated the 1.63.0 MSRV instructions to pin
reqwest-v0.12.9
, the last version with that MSRV. Laterreqwest
versions bump the MSRV to 1.64.0.