Add get raw block endpoint #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3358164056Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
benthecarman
force-pushed
the
get-block
branch
from
f089fef to
9d0bd2c
Compare
|
Fixed formatting |
tnull
reviewed
Oct 31, 2022
There was a problem hiding this comment.
Generally looks good, just two slight naming/doc suggestions.
(Btw, depending on your use case you might want to look into LDK's Confirm interface that allows syncing without supplying full blocks and hence is probably the better choice for most lighter weight client applications that would choose Esplora/Electrum.)
benthecarman
force-pushed
the
get-block
branch
from
9d0bd2c to
199c6ec
Compare
|
Responded to @tnull's comments |
vladimirfomene
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed for implementing LDKs
BlockSourcetrait