Skip to content

WIP: Integrate SpQR + FSDP functionalities #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Titus-von-Koeller
Copy link
Collaborator

No description provided.

TimDettmers and others added 30 commits August 5, 2023 16:47
@Titus-von-Koeller Titus-von-Koeller changed the title WIP: SpQR and FSDP integrations WIP: Integrate SpQR + FSDP functionalities Oct 23, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

@github-actions github-actions bot closed this Dec 30, 2023
@TimDettmers TimDettmers reopened this Jan 1, 2024
@TimDettmers TimDettmers added High Priority (first issues that will be worked on) High Risk Risk of bugs in transformers and other libraries labels Jan 1, 2024
@github-actions github-actions bot closed this Jan 10, 2024
@younesbelkada younesbelkada reopened this Jan 10, 2024
Titus-von-Koeller pushed a commit that referenced this pull request Jan 17, 2024
This PR adds initial FSDP support for training QLoRA models. It enables basic FSDP and CPU Offload support, with low memory training via FSDP.sync_module_states option unsupported.

This PR builds off of #840 commit 8278fca and BNB FSDP by @TimDettmers and @Titus-von-Koeller.

An example of using this PR to finetune QLoRA models with FSDP can be found in the demo repo: AnswerDotAi/fsdp_qlora.

* Minimal changes for fp32 4bit storage from BNB commit 8278fca

* Params4bit with selectable storage dtype

* possible fix for double quantizing linear weight & quant storage dtype

* minor fixes in Params4bit for peft tests

* remove redundant

* add float16

* update test

* Remove float16 quant cast as there are fp32, bf16, & fp16 quant kernels

---------

Co-authored-by: Kerem Turgutlu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority (first issues that will be worked on) High Risk Risk of bugs in transformers and other libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants