Skip to content

VuePress 2.0-rc0 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jan 17, 2024
Merged

VuePress 2.0-rc0 #83

merged 21 commits into from
Jan 17, 2024

Conversation

jonashendrickx
Copy link

@jonashendrickx jonashendrickx commented Jan 16, 2024

image

Search bar has moved to the right, not something we can control I think. But now offers shortcuts. Uses the same provider Algolia for indexing.

image

The tabs keep in sync with eachother.

image

@jonashendrickx jonashendrickx requested a review from abergs January 16, 2024 14:39
Copy link

cloudflare-workers-and-pages bot commented Jan 16, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ba0e2a3
Status: ✅  Deploy successful!
Preview URL: https://7923007e.passwordless-docs.pages.dev
Branch Preview URL: https://vuepress2.passwordless-docs.pages.dev

View logs

@abergs
Copy link
Member

abergs commented Jan 16, 2024

CleanShot 2024-01-16 at 15 53 35

Get started button missing.

@abergs
Copy link
Member

abergs commented Jan 16, 2024

For some reason, the installation instruction are not visible:

https://vuepress2.passwordless-docs.pages.dev/guide/frontend/javascript.html

CleanShot 2024-01-16 at 15 56 33

@jonashendrickx jonashendrickx marked this pull request as draft January 16, 2024 18:14
@jonashendrickx jonashendrickx marked this pull request as ready for review January 16, 2024 18:55
@jonashendrickx jonashendrickx linked an issue Jan 17, 2024 that may be closed by this pull request
Copy link
Member

@abergs abergs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jonashendrickx jonashendrickx merged commit c2223f2 into main Jan 17, 2024
@jonashendrickx jonashendrickx deleted the vuepress2 branch January 17, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigating to a specific header by ID seems broken
2 participants