fix #31012 allow noEmitOnError with isolatedModules #34
+11
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheiber
force-pushed
the
isolated-modules-no-emit-on-error
branch
from
8ac3e09 to
cc8f5a6
Compare
fix microsoft#31012 Since the purpose of isolatedModules: true is to do extra validation to ensure that separate compilation is safe Allowing emit in the presence of errors is compatible with that intention. Signed-off-by: Max Heiber <[email protected]>
mheiber
force-pushed
the
isolated-modules-no-emit-on-error
branch
from
cc8f5a6 to
218b927
Compare
mheiber
changed the title
4 tasks
mheiber
changed the base branch from
master
to
permit-isolated-modules-with-no-emit-on-error
mheiber
merged commit 94a67d3
into
bloomberg:permit-isolated-modules-with-no-emit-on-error
joeywatts
pushed a commit
that referenced
this pull request
May 9, 2019
…1043) fix microsoft#31012 Since the purpose of isolatedModules: true is to do extra validation to ensure that separate compilation is safe Allowing emit in the presence of errors is compatible with that intention. Signed-off-by: Max Heiber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix microsoft#31012 allow noEmitOnError with isolatedModules
The intent of isolatedModules: true is to
do extra validation to ensure that separate
compilation is safe.
Allowing emit in the presence of errors is
compatible with that intention.